Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Issue 565023002: IndexedDB: Switched two Iterator::Seek calls to Transaction::Get. (Closed)

Created:
6 years, 3 months ago by cmumford
Modified:
6 years, 3 months ago
Reviewers:
jsbell
CC:
chromium-reviews, darin-cc_chromium.org, dgrogan, jsbell+idb_chromium.org, jam, cmumford
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

IndexedDB: Switched two Iterator::Seek calls to Transaction::Get. Switching for two reasons: 1. Semantics are simpler because, in each of these cases, there was never a subsequent iteration - just a check to see if the iterator key matched the desired key. 2. The Transaction::Get() call uses the LevelDB filter which (when enabled) can significantly reduce disk reads, thus improving performance. This change, along with enabling the bloom filter, resolves a performance issue introduced by r273048. BUG=409520 Committed: https://crrev.com/7eff2e4b1a12584cd89f48ca3b9879faa37ebedc Cr-Commit-Position: refs/heads/master@{#294675}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -9 lines) Patch
M content/browser/indexed_db/indexed_db_backing_store.cc View 3 chunks +11 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
cmumford
I felt this change was good to do even if we don't enable the Bloom ...
6 years, 3 months ago (2014-09-11 23:51:56 UTC) #2
jsbell
lgtm
6 years, 3 months ago (2014-09-11 23:56:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/565023002/1
6 years, 3 months ago (2014-09-12 21:00:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 11304957eb3934100d364215085bf739430db2f2
6 years, 3 months ago (2014-09-12 22:06:48 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 22:12:38 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7eff2e4b1a12584cd89f48ca3b9879faa37ebedc
Cr-Commit-Position: refs/heads/master@{#294675}

Powered by Google App Engine
This is Rietveld 408576698