Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 564993002: Embedded Extension Options: remove flags and trunk channel restrictions (Closed)

Created:
6 years, 3 months ago by ericzeng
Modified:
6 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, not at google - send to devlin
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Embedded Extension Options: remove flags and trunk channel restrictions Remove flags and change trunk channel restrictions to dev in preparation for launch. BUG=386830 Committed: https://crrev.com/f51d745370bf88beeb3e9a5da4a64b5cebea8028 Cr-Commit-Position: refs/heads/master@{#294666}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -93 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_webui_apitest.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/common/extensions/api/_api_features.json View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/_permission_features.json View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_options_unittest.cc View 3 chunks +0 lines, -26 lines 0 comments Download
M chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M extensions/browser/guest_view/extension_options/extension_options_apitest.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M extensions/browser/guest_view/extension_options/extension_options_guest.cc View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M extensions/common/feature_switch.h View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/common/feature_switch.cc View 3 chunks +0 lines, -7 lines 0 comments Download
M extensions/common/manifest_handlers/options_page_info.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M extensions/common/switches.h View 1 chunk +0 lines, -2 lines 0 comments Download
M extensions/common/switches.cc View 2 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
ericzeng
PTAL
6 years, 3 months ago (2014-09-12 00:19:40 UTC) #2
ericzeng
Hey, could you all review this as soon as possible? Today is my last day, ...
6 years, 3 months ago (2014-09-12 20:23:00 UTC) #3
Fady Samuel
guest_view lgtm
6 years, 3 months ago (2014-09-12 20:26:07 UTC) #4
not at google - send to devlin
lgtm
6 years, 3 months ago (2014-09-12 20:26:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/564993002/20001
6 years, 3 months ago (2014-09-12 20:32:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/564993002/40001
6 years, 3 months ago (2014-09-12 20:35:59 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 761e46d0676510b3a4cc7316d930e1b04abcc466
6 years, 3 months ago (2014-09-12 21:38:35 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 21:44:01 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f51d745370bf88beeb3e9a5da4a64b5cebea8028
Cr-Commit-Position: refs/heads/master@{#294666}

Powered by Google App Engine
This is Rietveld 408576698