Add support for dark theme in Mac Notification Center

ui/message_center/cocoa/status_item_view.mm

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ui/message_center/cocoa/status_item_view.h"
 
 #include <cmath>
 
 #include "base/format_macros.h"
+#include "base/mac/sdk_forward_declarations.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/resources/grit/ui_resources.h"
 
 // The width of the status bar item when it's just the icon.
 const CGFloat kStatusItemLength = 26;
 
 // The amount of space between the left and right edges and the content of the
 // status item.
 const CGFloat kMargin = 5;
 
@@ skipping 121 matching lines @@
 
 // Private /////////////////////////////////////////////////////////////////////
 
 - (BOOL)shouldHighlight {
   return highlight_ || inMouseEventSequence_;
 }
 
 - (int)getTrayResourceId {
   BOOL highlight = [self shouldHighlight];
   BOOL hasUnreadItems = unreadCount_ > 0;
-  int kResourceIds[2][2][2] = {
+  BOOL dark = NO;
+  if ([self respondsToSelector:@selector(effectiveAppearance)]) {
+    NSString* appearanceName = [[self effectiveAppearance] name];
+    dark = (appearanceName != nil) &&

[Robert Sesek, 2014/09/12 19:16:23]

You can drop the nil check. Messaging nil will always return a 0 value.

[dewittj, 2014/09/12 23:24:20]

Done.

+        [appearanceName isEqualToString:NSAppearanceNameVibrantDark];
+  }
+
+  int kResourceIds[2][2][2][2] = {

[dewittj, 2014/09/12 18:15:36]

Wondering now if I should use a bitmask to index into an array of resource
names.  WDYT?

[Robert Sesek, 2014/09/12 19:16:23]

I'd be fine with either. Your call.

[dewittj, 2014/09/12 23:24:20]

Acknowledged.

     {
-      { IDR_TRAY_EMPTY, IDR_TRAY_EMPTY_PRESSED },
-      { IDR_TRAY_ATTENTION, IDR_TRAY_ATTENTION_PRESSED },
+      {
+        { IDR_TRAY_EMPTY, IDR_TRAY_EMPTY_PRESSED },
+        { IDR_TRAY_ATTENTION, IDR_TRAY_ATTENTION_PRESSED },
+      },
+      {
+        { IDR_TRAY_DO_NOT_DISTURB_EMPTY,
+          IDR_TRAY_DO_NOT_DISTURB_EMPTY_PRESSED },
+        { IDR_TRAY_DO_NOT_DISTURB_ATTENTION,
+          IDR_TRAY_DO_NOT_DISTURB_ATTENTION_PRESSED },
+      },
     },
     {
-      { IDR_TRAY_DO_NOT_DISTURB_EMPTY,
-        IDR_TRAY_DO_NOT_DISTURB_EMPTY_PRESSED },
-      { IDR_TRAY_DO_NOT_DISTURB_ATTENTION,
-        IDR_TRAY_DO_NOT_DISTURB_ATTENTION_PRESSED },
-    },
+      {
+        { IDR_DARK_TRAY_EMPTY, IDR_DARK_TRAY_EMPTY_PRESSED },
+        { IDR_DARK_TRAY_ATTENTION, IDR_DARK_TRAY_ATTENTION_PRESSED },
+      },
+      {
+        { IDR_DARK_TRAY_DO_NOT_DISTURB_EMPTY,
+          IDR_DARK_TRAY_DO_NOT_DISTURB_EMPTY_PRESSED },
+        { IDR_DARK_TRAY_DO_NOT_DISTURB_ATTENTION,
+          IDR_DARK_TRAY_DO_NOT_DISTURB_ATTENTION_PRESSED },
+      },
+    }
   };
-  return kResourceIds[quietMode_][hasUnreadItems][highlight];
+  return kResourceIds[dark][quietMode_][hasUnreadItems][highlight];
 }
 
 @end