Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(695)

Issue 564933002: GuestView: Double clicking a GuestView type in task manager should activate the embedder. (Closed)

Created:
6 years, 3 months ago by Fady Samuel
Modified:
6 years, 3 months ago
Reviewers:
lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

GuestView: Double clicking a GuestView type in task manager should activate the embedder. This is a useful debug aid and better matches the behavior of tabs. BUG=none Committed: https://crrev.com/2d19fb1182fe156ff09b587d112da8ede8ccec58 Cr-Commit-Position: refs/heads/master@{#294443}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M extensions/browser/guest_view/guest_view_base.h View 1 chunk +3 lines, -0 lines 0 comments Download
M extensions/browser/guest_view/guest_view_base.cc View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Fady Samuel
A simple behavioral tweak to make debugging a little easier.
6 years, 3 months ago (2014-09-11 18:11:13 UTC) #2
lazyboy
lgtm
6 years, 3 months ago (2014-09-11 18:16:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/564933002/1
6 years, 3 months ago (2014-09-11 18:19:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as cb36ea3fa1b37108f6d94d9587f22eaab7dd6893
6 years, 3 months ago (2014-09-11 19:33:13 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 19:43:32 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2d19fb1182fe156ff09b587d112da8ede8ccec58
Cr-Commit-Position: refs/heads/master@{#294443}

Powered by Google App Engine
This is Rietveld 408576698