Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 564923003: Test that gesture events are created with correct coordinates. (Closed)

Created:
6 years, 3 months ago by tdresser
Modified:
6 years, 3 months ago
Reviewers:
sadrul
CC:
chromium-reviews, sadrul, ben+aura_chromium.org, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Test that gesture events are created with correct coordinates. BUG=412875 TEST=WindowEventDispatcherTest.GestureEventCoordinates Committed: https://crrev.com/4fc3e94be7a4851ca52a52c59b1dd498c9d60dca Cr-Commit-Position: refs/heads/master@{#294626}

Patch Set 1 #

Patch Set 2 : More general test. #

Patch Set 3 : Fix windows compile. #

Total comments: 4

Patch Set 4 : Address sadrul's comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -0 lines) Patch
M ui/aura/window_event_dispatcher_unittest.cc View 1 2 3 5 chunks +63 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
tdresser
6 years, 3 months ago (2014-09-12 13:16:35 UTC) #2
sadrul
LGTM https://codereview.chromium.org/564923003/diff/40001/ui/aura/window_event_dispatcher_unittest.cc File ui/aura/window_event_dispatcher_unittest.cc (right): https://codereview.chromium.org/564923003/diff/40001/ui/aura/window_event_dispatcher_unittest.cc#newcode2305 ui/aura/window_event_dispatcher_unittest.cc:2305: gfx::PointF(event->x() + window_offset_, event->y() + window_offset_)); event->ConvertLocationToTarget(window_, window_->GetRootWindow()) ...
6 years, 3 months ago (2014-09-12 15:48:34 UTC) #3
tdresser
https://codereview.chromium.org/564923003/diff/40001/ui/aura/window_event_dispatcher_unittest.cc File ui/aura/window_event_dispatcher_unittest.cc (right): https://codereview.chromium.org/564923003/diff/40001/ui/aura/window_event_dispatcher_unittest.cc#newcode2305 ui/aura/window_event_dispatcher_unittest.cc:2305: gfx::PointF(event->x() + window_offset_, event->y() + window_offset_)); On 2014/09/12 15:48:33, ...
6 years, 3 months ago (2014-09-12 16:57:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/564923003/60001
6 years, 3 months ago (2014-09-12 16:59:21 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001) as 90ba35242f412be10996a73f04e67c964fd67e8c
6 years, 3 months ago (2014-09-12 19:17:19 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 19:20:39 UTC) #8
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/4fc3e94be7a4851ca52a52c59b1dd498c9d60dca
Cr-Commit-Position: refs/heads/master@{#294626}

Powered by Google App Engine
This is Rietveld 408576698