Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(944)

Unified Diff: extensions/renderer/resources/web_view_events.js

Issue 564913003: Moving web_view.js to extensions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/resources/web_view_events.js
diff --git a/chrome/renderer/resources/extensions/web_view_events.js b/extensions/renderer/resources/web_view_events.js
similarity index 98%
rename from chrome/renderer/resources/extensions/web_view_events.js
rename to extensions/renderer/resources/web_view_events.js
index 63c46d0276c98296e489c4674ae42ecdbe32dbcb..32b500ce23e83ca761c7223055845fa9db72216a 100644
--- a/chrome/renderer/resources/extensions/web_view_events.js
+++ b/extensions/renderer/resources/web_view_events.js
@@ -50,14 +50,6 @@ var WEB_VIEW_EVENTS = {
evt: CreateEvent('webViewInternal.onContentLoad'),
fields: []
},
- 'contextmenu': {
- evt: CreateEvent('chromeWebViewInternal.contextmenu'),
- cancelable: true,
- customHandler: function(handler, event, webViewEvent) {
- handler.handleContextMenu(event, webViewEvent);
- },
- fields: ['items']
- },
'dialog': {
cancelable: true,
customHandler: function(handler, event, webViewEvent) {
@@ -283,6 +275,10 @@ WebViewEvents.prototype.getEvents = function() {
for (var eventName in experimentalEvents) {
WEB_VIEW_EVENTS[eventName] = experimentalEvents[eventName];
}
+ var chromeEvents = this.webViewInternal.maybeGetChromeWebViewEvents();
+ for (var eventName in chromeEvents) {
+ WEB_VIEW_EVENTS[eventName] = chromeEvents[eventName];
+ }
return WEB_VIEW_EVENTS;
};
@@ -309,11 +305,6 @@ WebViewEvents.prototype.setupEvent = function(name, info) {
};
-// Event handlers.
-WebViewEvents.prototype.handleContextMenu = function(e, webViewEvent) {
- this.webViewInternal.maybeHandleContextMenu(e, webViewEvent);
-};
-
WebViewEvents.prototype.handleDialogEvent = function(event, webViewEvent) {
var showWarningMessage = function(dialogType) {
var VOWELS = ['a', 'e', 'i', 'o', 'u'];
« no previous file with comments | « extensions/renderer/resources/web_view_deny.js ('k') | extensions/renderer/resources/web_view_experimental.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698