Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Unified Diff: extensions/renderer/resources/web_view.js

Issue 564913003: Moving web_view.js to extensions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/resources/web_view.js
diff --git a/chrome/renderer/resources/extensions/web_view.js b/extensions/renderer/resources/web_view.js
similarity index 98%
rename from chrome/renderer/resources/extensions/web_view.js
rename to extensions/renderer/resources/web_view.js
index 63872ce214fd25e787c1093aaac06a257e2cbcdd..8e14f3844918ddcf6a7203b70f464318dd5c1087 100644
--- a/chrome/renderer/resources/extensions/web_view.js
+++ b/extensions/renderer/resources/web_view.js
@@ -14,6 +14,7 @@ var ChromeWebView = require('chromeWebViewInternal').ChromeWebView
// TODO(lazyboy): Rename this to WebViewInternal and call WebViewInternal
// something else.
var WebView = require('webViewInternal').WebView;
+var ChromeWebView = require('chromeWebViewInternal').ChromeWebView
lazyboy 2014/09/11 20:02:04 Accidental change? line #13 already includes this.
lfg 2014/09/11 21:17:20 Yes -- and they are not needed anymore, since cont
var WebViewEvents = require('webViewEvents').WebViewEvents;
var guestViewInternalNatives = requireNative('guest_view_internal');
@@ -1012,6 +1013,12 @@ window.addEventListener('readystatechange', function listener(event) {
}, useCapture);
/**
+ * Implemented when the ChromeWebView API is available.
+ * @private
+ */
+WebViewInternal.prototype.maybeGetChromeWebViewEvents = function() {};
+
+/**
* Implemented when the experimental API is available.
* @private
*/
@@ -1026,24 +1033,11 @@ WebViewInternal.prototype.maybeGetExperimentalPermissions = function() {
};
/**
- * Calls to show contextmenu right away instead of dispatching a 'contextmenu'
- * event.
- * This will be overridden in web_view_experimental.js to implement contextmenu
- * API.
- */
-WebViewInternal.prototype.maybeHandleContextMenu = function(e, webViewEvent) {
- var requestId = e.requestId;
- // Setting |params| = undefined will show the context menu unmodified, hence
- // the 'contextmenu' API is disabled for stable channel.
- var params = undefined;
- ChromeWebView.showContextMenu(this.guestInstanceId, requestId, params);
-};
-
-/**
* Implemented when the experimental API is available.
* @private
*/
-WebViewInternal.prototype.setupExperimentalContextMenus = function() {};
+WebViewInternal.prototype.setupExperimentalContextMenus = function() {
+};
exports.WebView = WebView;
exports.WebViewInternal = WebViewInternal;

Powered by Google App Engine
This is Rietveld 408576698