Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Side by Side Diff: Source/devtools/front_end/console/ConsoleView.js

Issue 564893002: DevTools: [Console] fix selection of all console messages (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2009 Joseph Pecoraro 3 * Copyright (C) 2009 Joseph Pecoraro
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 8 *
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
96 resetFiltersLink.textContent = WebInspector.UIString("Show all messages."); 96 resetFiltersLink.textContent = WebInspector.UIString("Show all messages.");
97 resetFiltersLink.addEventListener("click", this._filter.reset.bind(this._fil ter), true); 97 resetFiltersLink.addEventListener("click", this._filter.reset.bind(this._fil ter), true);
98 98
99 this._topGroup = WebInspector.ConsoleGroup.createTopGroup(); 99 this._topGroup = WebInspector.ConsoleGroup.createTopGroup();
100 this._currentGroup = this._topGroup; 100 this._currentGroup = this._topGroup;
101 101
102 this._promptElement = this._messagesElement.createChild("div", "source-code" ); 102 this._promptElement = this._messagesElement.createChild("div", "source-code" );
103 this._promptElement.id = "console-prompt"; 103 this._promptElement.id = "console-prompt";
104 this._promptElement.spellcheck = false; 104 this._promptElement.spellcheck = false;
105 105
106 // FIXME: This is a workaround for the selection machinery bug. See crbug.co m/410899
107 var selectAllFixer = this._messagesElement.createChild("div", "console-view- fix-select-all");
108 selectAllFixer.textContent = ".";
109
106 this._showAllMessagesCheckbox = new WebInspector.StatusBarCheckbox(WebInspec tor.UIString("Show all messages")); 110 this._showAllMessagesCheckbox = new WebInspector.StatusBarCheckbox(WebInspec tor.UIString("Show all messages"));
107 this._showAllMessagesCheckbox.inputElement.checked = true; 111 this._showAllMessagesCheckbox.inputElement.checked = true;
108 this._showAllMessagesCheckbox.inputElement.addEventListener("change", this._ updateMessageList.bind(this), false); 112 this._showAllMessagesCheckbox.inputElement.addEventListener("change", this._ updateMessageList.bind(this), false);
109 113
110 this._showAllMessagesCheckbox.element.classList.add("hidden"); 114 this._showAllMessagesCheckbox.element.classList.add("hidden");
111 115
112 statusBarElement.appendChild(this._showAllMessagesCheckbox.element); 116 statusBarElement.appendChild(this._showAllMessagesCheckbox.element);
113 117
114 this._registerShortcuts(); 118 this._registerShortcuts();
115 119
(...skipping 1112 matching lines...) Expand 10 before | Expand all | Expand 10 after
1228 WebInspector.ConsoleView.ShowConsoleActionDelegate.prototype = { 1232 WebInspector.ConsoleView.ShowConsoleActionDelegate.prototype = {
1229 /** 1233 /**
1230 * @return {boolean} 1234 * @return {boolean}
1231 */ 1235 */
1232 handleAction: function() 1236 handleAction: function()
1233 { 1237 {
1234 WebInspector.console.show(); 1238 WebInspector.console.show();
1235 return true; 1239 return true;
1236 } 1240 }
1237 } 1241 }
OLDNEW
« no previous file with comments | « LayoutTests/inspector/console/console-viewport-selection-expected.txt ('k') | Source/devtools/front_end/inspectorStyle.css » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698