Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 564873003: Make correction to grep pattern to grab git hash for given commit position. (Closed)

Created:
6 years, 3 months ago by prasadv
Modified:
6 years, 3 months ago
Reviewers:
tonyg, qyearsley
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Make correction to grep pattern to grab git hash for given commit position. Note that the pattern used to check commit position appears two times in reverted CL, therefore match the pattern at begining of the line BUG=413365, 412054 NOTRY=true Committed: https://crrev.com/657e7fb46a5eff1680d2b079dcaebfea4e4c19a4 Cr-Commit-Position: refs/heads/master@{#294463}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/auto_bisect/source_control.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
prasadv
6 years, 3 months ago (2014-09-11 19:50:14 UTC) #2
qyearsley
lgtm
6 years, 3 months ago (2014-09-11 20:32:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/564873003/1
6 years, 3 months ago (2014-09-11 20:39:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 7178ccdf3e7bdf2a24df396cdfe8bc63f7bd180a
6 years, 3 months ago (2014-09-11 20:58:22 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 21:22:47 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/657e7fb46a5eff1680d2b079dcaebfea4e4c19a4
Cr-Commit-Position: refs/heads/master@{#294463}

Powered by Google App Engine
This is Rietveld 408576698