Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 564863003: IPC: Add more debug info. (Closed)

Created:
6 years, 3 months ago by rvargas (doing something else)
Modified:
6 years, 3 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

IPC: Add more debug info. We're still seeing crashes that appear to come from multiple simultaneous writes. Given that writing_ is false when we crash, but the operation matches the current thread, file handle and IPC Channel, it could be that for some reason a failed Write is still genarating a notification. So this CL stores two error codes (one for the current operation and another for a previous failure), and the write size. BUG=387876 R=cpu@chromium.org Committed: https://crrev.com/431ce7382e8cae58d1dfbdde7c5c8bdc27daee2b Cr-Commit-Position: refs/heads/master@{#294993}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -6 lines) Patch
M ipc/ipc_channel_win.h View 1 chunk +10 lines, -1 line 0 comments Download
M ipc/ipc_channel_win.cc View 3 chunks +11 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
rvargas (doing something else)
6 years, 3 months ago (2014-09-15 19:50:56 UTC) #1
cpu_(ooo_6.6-7.5)
lgtm
6 years, 3 months ago (2014-09-16 00:04:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/564863003/1
6 years, 3 months ago (2014-09-16 00:37:46 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as 0a01cd55dcfadfa196c8ba6f3ab641aaa7e4b2d6
6 years, 3 months ago (2014-09-16 02:45:29 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 02:48:03 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/431ce7382e8cae58d1dfbdde7c5c8bdc27daee2b
Cr-Commit-Position: refs/heads/master@{#294993}

Powered by Google App Engine
This is Rietveld 408576698