Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 564853002: Add third_party/apple_cctools containing virgin upstream code (Closed)

Created:
6 years, 3 months ago by Mark Mentovai
Modified:
6 years, 3 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

Add third_party/apple_cctools containing virgin upstream code. getsectionbyname() and getsegmentbyname() do not exist prior to Mac OS X 10.7. These functions are used by util_test MachOImageReader.*. For 10.6 SDK and runtime compatibility, Crashpad needs its own implementations of these functions. This checkin contains unmodified copies of the upstream code. A subsequent checkin will contain the local modifications, which will trim out all unnecessary portions. This is being committed in two parts to make it easier to see what changes are being made to the upstream files. R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/24fc801715a7bf9c91f34623a9f845afad97e6d7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1131 lines, -0 lines) Patch
A third_party/apple_cctools/README.crashpad View 1 chunk +24 lines, -0 lines 0 comments Download
A third_party/apple_cctools/cctools/APPLE_LICENSE View 1 chunk +367 lines, -0 lines 0 comments Download
A third_party/apple_cctools/cctools/include/mach-o/getsect.h View 1 chunk +143 lines, -0 lines 0 comments Download
A third_party/apple_cctools/cctools/libmacho/getsecbyname.c View 1 chunk +597 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Mark Mentovai
6 years, 3 months ago (2014-09-11 15:38:36 UTC) #2
Robert Sesek
No GYP file? Otherwise, stamp LGTM.
6 years, 3 months ago (2014-09-11 18:44:44 UTC) #3
Mark Mentovai
There’s no .gyp file because it doesn’t build in our environment as-is in its upstream ...
6 years, 3 months ago (2014-09-11 18:55:02 UTC) #4
Mark Mentovai
6 years, 3 months ago (2014-09-11 19:11:54 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 24fc801 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698