Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 564833002: Fix needless environment scan in safe browsing incident reporting service. (Closed)

Created:
6 years, 3 months ago by grt (UTC plus 2)
Modified:
6 years, 3 months ago
Reviewers:
robertshield
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix needless environment scan in safe browsing incident reporting service. BUG=413233 R=robertshield@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/8b31eb21cd7319fde2d3d043228f753b47c4137e

Patch Set 1 #

Total comments: 2

Patch Set 2 : comment tweak #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -1 line) Patch
M chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/incident_reporting_service_unittest.cc View 1 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
grt (UTC plus 2)
6 years, 3 months ago (2014-09-11 15:07:35 UTC) #1
robertshield
lgtm
6 years, 3 months ago (2014-09-11 15:32:48 UTC) #2
robertshield
https://codereview.chromium.org/564833002/diff/1/chrome/browser/safe_browsing/incident_reporting/incident_reporting_service_unittest.cc File chrome/browser/safe_browsing/incident_reporting/incident_reporting_service_unittest.cc (right): https://codereview.chromium.org/564833002/diff/1/chrome/browser/safe_browsing/incident_reporting/incident_reporting_service_unittest.cc#newcode804 chrome/browser/safe_browsing/incident_reporting/incident_reporting_service_unittest.cc:804: // Confirm that the callback were not run. s/were/was/
6 years, 3 months ago (2014-09-11 15:33:29 UTC) #3
grt (UTC plus 2)
Thanks. I'll git cl land this once the tryjobs on patch set 1 are all ...
6 years, 3 months ago (2014-09-11 15:40:39 UTC) #4
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/8b31eb21cd7319fde2d3d043228f753b47c4137e Cr-Commit-Position: refs/heads/master@{#294398}
6 years, 3 months ago (2014-09-11 16:21:43 UTC) #5
grt (UTC plus 2)
6 years, 3 months ago (2014-09-11 16:21:52 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 8b31eb2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698