Issue 5648005: [binutils] allow immediates in naclrest{bp,sp}

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5648005: [binutils] allow immediates in naclrest{bp,sp} (Closed)

Created:
10 years ago by pasko-google - do not use

Modified:
9 years, 7 months ago

Reviewers:
khim

CC:
native-client-reviews_googlegroups.com

Base URL:
ssh://git@gitrw.chromium.org:9222/nacl-toolchain.git@master

Visibility:
Public.

Description

[binutils] allow immediates in naclrest{bp,sp} Originally these commands would have produced an error in nacl64-as: naclrestbp $0, %r15 naclrestsp $0, %r15 Error: suffix or operands invalid for `naclrestbp' 8bit immediates would be extended to 32bit. BUG= TEST= Committed: http://git.chromium.org/gitweb/?p=nacl-toolchain.git;a=commit;h=95dcbc2

Patch Set 1 #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -11 lines)			Patch
	M	binutils/gas/config/tc-i386.c	View		3 chunks	+20 lines, -11 lines	0 comments	Download
	M	binutils/opcodes/i386-opc.tbl	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages