components/translate.gypi - Issue 564793003: Move TranslateHelper to the translate component.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/translate.gypi

Issue 564793003: Move TranslateHelper to the translate component. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@translateBrowserIPC

Patch Set: fix gn Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/translate/translate_helper_browsertest.cc ('k') | components/translate/content/renderer/BUILD.gn » ('j') | components/translate/content/renderer/DEPS » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/translate.gypi

diff --git a/components/translate.gypi b/components/translate.gypi

index 1280e578deee56766bdd10d8fc4124f6ea4e9fbc..2be7c32b260b5c2572df056059aff93081886d65 100644

--- a/components/translate.gypi

+++ b/components/translate.gypi

@@ -206,9 +206,16 @@

'target_name': 'translate_content_renderer',

'type': 'static_library',

'dependencies': [

+ 'translate_content_common',

+ 'translate_core_common',

+ 'translate_core_language_detection',

'../base/base.gyp:base',

'../content/content.gyp:content_common',

+ '../content/content.gyp:content_renderer',

'../ipc/ipc.gyp:ipc',

+ '../third_party/WebKit/public/blink.gyp:blink',

+ '../url/url.gyp:url_lib',

+ '../v8/tools/gyp/v8.gyp:v8',

'include_dirs': [

'..',

@@ -216,6 +223,8 @@

'sources': [

# Note: sources list duplicated in GN build.

'translate/content/renderer/renderer_cld_data_provider.h',

+ 'translate/content/renderer/translate_helper.cc',

+ 'translate/content/renderer/translate_helper.h',

'conditions': [

['cld_version==0 or cld_version==2', {