chrome/renderer/chrome_render_view_observer.cc - Issue 564793003: Move TranslateHelper to the translate component.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/chrome_render_view_observer.cc

Issue 564793003: Move TranslateHelper to the translate component. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@translateBrowserIPC

Patch Set: fix gn Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/chrome_render_view_observer.h ('k') | chrome/renderer/translate/translate_helper.h » ('j') | components/translate/content/renderer/DEPS » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/chrome_render_view_observer.cc

diff --git a/chrome/renderer/chrome_render_view_observer.cc b/chrome/renderer/chrome_render_view_observer.cc

index 5ab3470d4f4fc77cb6de4578a3fb1fd28dfd57a7..454feaf7e4d0e49365f381552af436864f62c5c4 100644

--- a/chrome/renderer/chrome_render_view_observer.cc

+++ b/chrome/renderer/chrome_render_view_observer.cc

@@ -18,15 +18,17 @@

#include "chrome/common/render_messages.h"

#include "chrome/common/url_constants.h"

#include "chrome/renderer/chrome_render_process_observer.h"

+#include "chrome/renderer/isolated_world_ids.h"

#include "chrome/renderer/prerender/prerender_helper.h"

#include "chrome/renderer/safe_browsing/phishing_classifier_delegate.h"

-#include "chrome/renderer/translate/translate_helper.h"

#include "chrome/renderer/webview_color_overlay.h"

+#include "components/translate/content/renderer/translate_helper.h"

#include "content/public/common/bindings_policy.h"

#include "content/public/renderer/content_renderer_client.h"

#include "content/public/renderer/render_frame.h"

#include "content/public/renderer/render_view.h"

#include "extensions/common/constants.h"

+#include "extensions/renderer/extension_groups.h"

#include "net/base/data_url.h"

#include "skia/ext/platform_canvas.h"

#include "third_party/WebKit/public/platform/WebCString.h"

@@ -157,7 +159,11 @@ ChromeRenderViewObserver::ChromeRenderViewObserver(

ChromeRenderProcessObserver* chrome_render_process_observer)

: content::RenderViewObserver(render_view),

chrome_render_process_observer_(chrome_render_process_observer),

- translate_helper_(new TranslateHelper(render_view)),

+ translate_helper_(new translate::TranslateHelper(

+ render_view,

+ chrome::ISOLATED_WORLD_ID_TRANSLATE,

+ extensions::EXTENSION_GROUP_INTERNAL_TRANSLATE_SCRIPTS,

+ extensions::kExtensionScheme)),

phishing_classifier_(NULL),

capture_timer_(false, false) {

const CommandLine& command_line = *CommandLine::ForCurrentProcess();