Issue 564763002: Reenable DevToolsSanityTest.TestDeviceEmulation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 564763002: Reenable DevToolsSanityTest.TestDeviceEmulation. (Closed)

Created:
6 years, 3 months ago by dgozman

Modified:
6 years, 3 months ago

Reviewers:
pfeldman

CC:
chromium-reviews, vsevik, yurys, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Reenable DevToolsSanityTest.TestDeviceEmulation. BUG=397889 TBR=pfeldman@chromium.org Committed: https://crrev.com/8844a8eba4465ff5f66bff5b7db195a0192625c3 Cr-Commit-Position: refs/heads/master@{#294375}

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	chrome/browser/devtools/devtools_sanity_browsertest.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/564763002/1

6 years, 3 months ago (2014-09-11 11:58:55 UTC) #2

commit-bot: I haz the power

Committed patchset #1 (id:1) as 8561b1349ed8a96cef1d5a0b42a3562ae71c5938

6 years, 3 months ago (2014-09-11 12:56:21 UTC) #3

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/8844a8eba4465ff5f66bff5b7db195a0192625c3 Cr-Commit-Position: refs/heads/master@{#294375}

6 years, 3 months ago (2014-09-11 12:58:39 UTC) #4

nasko

6 years, 3 months ago (2014-09-11 18:35:16 UTC) #5

Message was sent while issue was closed.

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/562343002/ by nasko@chromium.org.

The reason for reverting is: Fails on the main waterfall on Windows and Linux:

https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20(dbg)(2)/bu...
https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20(dbg)(1)...
.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages