Move Translate browser-side IPC handling to the component.

Move Translate browser-side IPC handling to the component.

This CL moves a bit of translate logic from chrome/ to the translate
component.

Some IPC messages are still forwarded to chrome (through
ContentTranslateDriver::Observer) because of translate notifications.
This is temporary though, because once translate notifications are
removed, ChromeTranslateClient will no longer need to be an Observer.

Another motivation for this change is that the renderer-side of translate
IPC (TranslateHelper) is moving to the component (in another CL),
and thus the browser-side has to move too for consistency (this CL).

BUG=335087
TBR=msw

Committed: https://crrev.com/38f0d1063fefeba088320c4932c51061f0922f74
Cr-Commit-Position: refs/heads/master@{#295073}

[droger, 2014-09-11 13:23:15]

Patchset #2 (id:20001) has been deleted

[droger, 2014-09-11 13:41:44]

Patchset #1 (id:1) has been deleted

[droger, 2014-09-11 13:50:04]

droger@chromium.org changed reviewers:
+ toyoshim@chromium.org

[Takashi Toyoshima, 2014-09-16 06:32:47]

Sorry, I was out of my desk in a few days.

I might be confused about TranslateDriver and ContentTranslateDriver, but I want
to understand it here.

https://codereview.chromium.org/564743002/diff/40001/chrome/browser/translate...
File chrome/browser/translate/chrome_translate_client.cc (right):

https://codereview.chromium.org/564743002/diff/40001/chrome/browser/translate...
chrome/browser/translate/chrome_translate_client.cc:283: //
TranslateDriver::Observer directly instead.
I guess this means ContentTranslateDriver::Observer.

https://codereview.chromium.org/564743002/diff/40001/chrome/browser/translate...
chrome/browser/translate/chrome_translate_client.cc:294: // TODO: Remove
translate notifications and have the clients be
ditto

https://codereview.chromium.org/564743002/diff/40001/chrome/browser/translate...
File chrome/browser/translate/chrome_translate_client.h (right):

https://codereview.chromium.org/564743002/diff/40001/chrome/browser/translate...
chrome/browser/translate/chrome_translate_client.h:99: //
TranslateDriver::Observer implementation.
ContentTranslateDriver::Observer?

https://codereview.chromium.org/564743002/diff/40001/chrome/browser/ui/browse...
File chrome/browser/ui/browser.cc (right):

https://codereview.chromium.org/564743002/diff/40001/chrome/browser/ui/browse...
chrome/browser/ui/browser.cc:2248: if (delegate) {
This is not your change, but using set_delegate inside the if () looks clearer.

[droger, 2014-09-16 10:57:13]

https://codereview.chromium.org/564743002/diff/40001/chrome/browser/translate...
File chrome/browser/translate/chrome_translate_client.cc (right):

https://codereview.chromium.org/564743002/diff/40001/chrome/browser/translate...
chrome/browser/translate/chrome_translate_client.cc:283: //
TranslateDriver::Observer directly instead.
On 2014/09/16 06:32:47, Takashi Toyoshima (chromium) wrote:
> I guess this means ContentTranslateDriver::Observer.

Correct. Done.

[Takashi Toyoshima, 2014-09-16 11:36:23]

Thanks. LGTM.

[droger, 2014-09-16 15:02:38]

droger@chromium.org changed reviewers:
+ msw@chromium.org

[droger, 2014-09-16 15:03:07]

TBR=msw for chrome/browser/ui/browser.cc

[droger, 2014-09-16 15:03:15]

The CQ bit was checked by droger@chromium.org

[commit-bot: I haz the power, 2014-09-16 15:04:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/564743002/60001

[commit-bot: I haz the power, 2014-09-16 15:38:35]

Committed patchset #2 (id:60001) as e64c37d777fe61fb2c98c20d0339d3accae0d112

[commit-bot: I haz the power, 2014-09-16 15:40:26]

Patchset 2 (id:??) landed as
https://crrev.com/38f0d1063fefeba088320c4932c51061f0922f74
Cr-Commit-Position: refs/heads/master@{#295073}

[msw, 2014-09-16 18:55:10]

c/b/ui/browser.cc rubber stamp lgtm