Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 564713002: Web SQL: Remove more worker-related code. (Closed)

Created:
6 years, 3 months ago by tkent
Modified:
6 years, 3 months ago
Reviewers:
michaeln, haraken
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Project:
blink
Visibility:
Public.

Description

Web SQL: Remove more worker-related code. - Drop worker support from DatabaseClient. - Remove WorkerGlobalScope support of DatabaseContext::allowDatabaseAccess. BUG=397429 TEST=none; No behavior changes. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181857

Patch Set 1 #

Patch Set 2 : Fix Windows build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -58 lines) Patch
M Source/modules/webdatabase/DatabaseClient.h View 3 chunks +2 lines, -10 lines 0 comments Download
M Source/modules/webdatabase/DatabaseClient.cpp View 3 chunks +2 lines, -12 lines 0 comments Download
M Source/modules/webdatabase/DatabaseContext.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webdatabase/DatabaseContext.cpp View 2 chunks +4 lines, -8 lines 0 comments Download
M Source/modules/webdatabase/DatabaseManager.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/DatabaseClientImpl.cpp View 2 chunks +6 lines, -14 lines 0 comments Download
M Source/web/WebSharedWorkerImpl.cpp View 3 chunks +0 lines, -3 lines 0 comments Download
M Source/web/WorkerGlobalScopeProxyProviderImpl.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/web/WorkerPermissionClient.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/WorkerPermissionClient.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M public/web/WebWorkerPermissionClientProxy.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tkent
Please review this.
6 years, 3 months ago (2014-09-11 09:40:54 UTC) #2
haraken
LGTM
6 years, 3 months ago (2014-09-11 11:53:08 UTC) #3
michaeln
lgtm 2, thank you for doing this!
6 years, 3 months ago (2014-09-11 19:03:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/564713002/20001
6 years, 3 months ago (2014-09-11 23:08:27 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 23:42:48 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 181857

Powered by Google App Engine
This is Rietveld 408576698