Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 564683002: X87: Encapsulate megamorphic load/tail-call in hydrogen (Closed)

Created:
6 years, 3 months ago by Jing
Modified:
6 years, 3 months ago
Reviewers:
Weiliang, mvstanton
CC:
v8-dev, danno
Base URL:
https://github.com/v8/v8.git@bleeding_edge
Project:
v8
Visibility:
Public.

Description

X87: Encapsulate megamorphic load/tail-call in hydrogen port r23772. original commit message: To aid vector-based load ic work, we need to be able to handle the megamorphic load case in hydrogen. A simple approach is to wrap the probe activity in a hydrogen instruction. The instruction is novel in that it always tail-calls away. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -31 lines) Patch
M src/ic/x87/ic-x87.cc View 2 chunks +1 line, -19 lines 0 comments Download
M src/ic/x87/stub-cache-x87.cc View 6 chunks +13 lines, -7 lines 0 comments Download
M src/x87/lithium-codegen-x87.cc View 3 chunks +29 lines, -4 lines 0 comments Download
M src/x87/lithium-x87.h View 3 chunks +24 lines, -1 line 0 comments Download
M src/x87/lithium-x87.cc View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Jing
6 years, 3 months ago (2014-09-11 07:01:02 UTC) #2
Weiliang
lgtm
6 years, 3 months ago (2014-09-12 01:39:03 UTC) #3
Weiliang
6 years, 3 months ago (2014-09-12 01:42:54 UTC) #4
Committed as r23889

Powered by Google App Engine
This is Rietveld 408576698