Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 564663003: easy_unlock: When loading the easy-unlock app, make sure it's enabled (Closed)

Created:
6 years, 3 months ago by tbarzic
Modified:
6 years, 3 months ago
Reviewers:
Tim Song
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

easy_unlock: When loading the easy-unlock app, make sure it's enabled The extension gets disabled when Chrome goes to sleep. If it doesn't wake up for some reason, the app will stay disabled. To make sure this doesn't happen, enable the app after loading it (this should be no-op if the app is already enabled). TEST=Let a Chromebook battery drain while it's suspended. On next boot the easy unlock app should be enabled (provided that it was enabled when Chromebook was suspended). BUG=410082 Committed: https://crrev.com/0d60628cd8d33316f66330d89b46b77f04baba2e Cr-Commit-Position: refs/heads/master@{#294980}

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -26 lines) Patch
M chrome/browser/signin/easy_unlock_service.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/signin/easy_unlock_service.cc View 1 4 chunks +14 lines, -24 lines 2 comments Download

Messages

Total messages: 9 (2 generated)
tbarzic
6 years, 3 months ago (2014-09-15 21:26:50 UTC) #2
Tim Song
lgtm
6 years, 3 months ago (2014-09-15 23:53:06 UTC) #3
Tim Song
https://codereview.chromium.org/564663003/diff/20001/chrome/browser/signin/easy_unlock_service.cc File chrome/browser/signin/easy_unlock_service.cc (right): https://codereview.chromium.org/564663003/diff/20001/chrome/browser/signin/easy_unlock_service.cc#newcode7 chrome/browser/signin/easy_unlock_service.cc:7: #include <string> Why do you need this?
6 years, 3 months ago (2014-09-15 23:53:53 UTC) #4
tbarzic
https://codereview.chromium.org/564663003/diff/20001/chrome/browser/signin/easy_unlock_service.cc File chrome/browser/signin/easy_unlock_service.cc (right): https://codereview.chromium.org/564663003/diff/20001/chrome/browser/signin/easy_unlock_service.cc#newcode7 chrome/browser/signin/easy_unlock_service.cc:7: #include <string> On 2014/09/15 23:53:53, Tim Song wrote: > ...
6 years, 3 months ago (2014-09-16 00:05:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/564663003/20001
6 years, 3 months ago (2014-09-16 00:48:57 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as a92884c49e5c8846d1faf16348c2fee4648d53e4
6 years, 3 months ago (2014-09-16 02:18:48 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 02:21:06 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0d60628cd8d33316f66330d89b46b77f04baba2e
Cr-Commit-Position: refs/heads/master@{#294980}

Powered by Google App Engine
This is Rietveld 408576698