Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 564663002: Move bisect-perf-regression.py into auto_bisect directory. (Closed)

Created:
6 years, 3 months ago by qyearsley
Modified:
6 years, 2 months ago
Reviewers:
prasadv, tonyg
CC:
chromium-reviews, ojan, Sergiy Byelozyorov
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move bisect-perf-regression.py into auto_bisect directory. The purpose of this is to continue gathering all the related code together, and to make it easier to run pylint/tests for the main module which still contains most of the code. After doing this, pylint and the tests caught a couple of things -- one unused variable name, and after the script changed directory, some of the paths had to be modified as well. BUG= Committed: https://crrev.com/62edbcf1e8e5dd1386693b7b4b90169e72bd7300 Cr-Commit-Position: refs/heads/master@{#296847}

Patch Set 1 #

Patch Set 2 : Upload a config for doing a test run. #

Total comments: 2

Patch Set 3 : Update path to telemetry directory. #

Patch Set 4 : Fix path to bisect script in run-bisect-perf-regression.py. #

Patch Set 5 : Re-organized the paths used in run-bisect-perf-regression.py. #

Patch Set 6 : Use absolute paths. #

Patch Set 7 : Change bisect config. #

Patch Set 8 : Change bisect config for another try job #

Patch Set 9 : Rebased #

Patch Set 10 : Rebased and reset config file to default file (since its not needed to start try jobs now) #

Patch Set 11 : Revert changes in this CL involving self.src_cwd. #

Patch Set 12 : Revert changes to bisect config file again. #

Patch Set 13 : Add telemetry to PYTHONPATH for PRESUBMIT.py. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -3819 lines) Patch
M tools/auto_bisect/PRESUBMIT.py View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +4 lines, -1 line 0 comments Download
M tools/auto_bisect/README View 1 chunk +7 lines, -13 lines 0 comments Download
A + tools/auto_bisect/bisect_perf_regression.py View 1 2 3 4 5 6 7 8 9 10 9 chunks +31 lines, -21 lines 0 comments Download
A + tools/auto_bisect/bisect_perf_regression_test.py View 1 2 3 4 5 6 7 8 9 10 9 chunks +15 lines, -17 lines 0 comments Download
M tools/auto_bisect/bisect_utils.py View 1 2 3 4 5 6 7 8 9 10 1 chunk +0 lines, -1 line 0 comments Download
M tools/auto_bisect/source_control.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
D tools/bisect-perf-regression.py View 1 2 3 4 5 6 7 8 9 10 1 chunk +0 lines, -3406 lines 0 comments Download
D tools/bisect-perf-regression_test.py View 1 chunk +0 lines, -305 lines 0 comments Download
M tools/run-bisect-manual-test.py View 3 chunks +11 lines, -10 lines 0 comments Download
M tools/run-bisect-perf-regression.py View 1 2 3 4 5 6 7 8 11 chunks +31 lines, -44 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
qyearsley
https://codereview.chromium.org/564663002/diff/20001/tools/auto_bisect/bisect.cfg File tools/auto_bisect/bisect.cfg (right): https://codereview.chromium.org/564663002/diff/20001/tools/auto_bisect/bisect.cfg#newcode72 tools/auto_bisect/bisect.cfg:72: 'builder_port': '8341', This shouldn't be submitted, it's only just ...
6 years, 3 months ago (2014-09-11 16:38:38 UTC) #2
qyearsley
This CL isn't directly related to supporting full builds and functional bisects, so it's just ...
6 years, 3 months ago (2014-09-11 16:39:53 UTC) #3
tonyg
lgtm
6 years, 3 months ago (2014-09-16 00:36:02 UTC) #4
qyearsley
On 2014/09/16 00:36:02, tonyg wrote: > lgtm Update on this CL: I'm running into an ...
6 years, 3 months ago (2014-09-19 20:05:52 UTC) #5
qyearsley
Yay! With Prasad's help, I realized that self.src_cwd in BisectPerformanceMetrics isn't the source directory that ...
6 years, 2 months ago (2014-09-25 23:05:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/564663002/220001
6 years, 2 months ago (2014-09-25 23:08:54 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/13632)
6 years, 2 months ago (2014-09-25 23:22:13 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/564663002/240001
6 years, 2 months ago (2014-09-25 23:53:29 UTC) #12
commit-bot: I haz the power
Committed patchset #13 (id:240001) as fc6a61c6dad6ca8865bd90028003d4c8bf20ae77
6 years, 2 months ago (2014-09-26 01:19:44 UTC) #13
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 01:20:15 UTC) #14
Message was sent while issue was closed.
Patchset 13 (id:??) landed as
https://crrev.com/62edbcf1e8e5dd1386693b7b4b90169e72bd7300
Cr-Commit-Position: refs/heads/master@{#296847}

Powered by Google App Engine
This is Rietveld 408576698