Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 564523003: Remove unused variable ios_mac_build (Closed)

Created:
6 years, 3 months ago by sdefresne
Modified:
6 years, 3 months ago
Reviewers:
justincohen, qsr
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove unused variable ios_mac_build The variable is set in this file but there is no other references to it in the code base. BUG=None Committed: https://crrev.com/0478f24c7e4602da7bcb317eabfa863467d85fbc Cr-Commit-Position: refs/heads/master@{#294847}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M build/ios/mac_build.gypi View 1 chunk +0 lines, -2 lines 2 comments Download

Messages

Total messages: 17 (7 generated)
sdefresne
Please take a look. This variable is used neither upstream nor downstream.
6 years, 3 months ago (2014-09-15 10:21:11 UTC) #2
justincohen
lgtm https://codereview.chromium.org/564523003/diff/1/build/ios/mac_build.gypi File build/ios/mac_build.gypi (left): https://codereview.chromium.org/564523003/diff/1/build/ios/mac_build.gypi#oldcode71 build/ios/mac_build.gypi:71: '-Dios_mac_build=1', Do you know where we ever used ...
6 years, 3 months ago (2014-09-15 13:44:52 UTC) #4
sdefresne
Thank you. https://codereview.chromium.org/564523003/diff/1/build/ios/mac_build.gypi File build/ios/mac_build.gypi (left): https://codereview.chromium.org/564523003/diff/1/build/ios/mac_build.gypi#oldcode71 build/ios/mac_build.gypi:71: '-Dios_mac_build=1', On 2014/09/15 13:44:51, justincohen wrote: > ...
6 years, 3 months ago (2014-09-15 15:16:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/564523003/1
6 years, 3 months ago (2014-09-15 15:17:20 UTC) #8
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 3 months ago (2014-09-15 15:17:23 UTC) #10
sdefresne
+qsr for committer LGTM
6 years, 3 months ago (2014-09-15 15:31:08 UTC) #12
qsr
RS LGTM
6 years, 3 months ago (2014-09-15 15:31:22 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/564523003/1
6 years, 3 months ago (2014-09-15 15:32:50 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1) as 55693d0ec7d870d87f02470904b3cc26c15bcb45
6 years, 3 months ago (2014-09-15 17:46:39 UTC) #16
commit-bot: I haz the power
6 years, 3 months ago (2014-09-15 17:56:29 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0478f24c7e4602da7bcb317eabfa863467d85fbc
Cr-Commit-Position: refs/heads/master@{#294847}

Powered by Google App Engine
This is Rietveld 408576698