Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 564473002: Makes loading test resources load the first supported scale factor (Closed)

Created:
6 years, 3 months ago by sky
Modified:
6 years, 3 months ago
Reviewers:
oshima
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Makes loading test resources load the first supported scale factor This is necessary as we don't always load 1x resources. In particular when I run views_example_exe with --force-device-scale-factor=2 then 1x isn't loaded. BUG=none TEST=none R=oshima@chromium.org Committed: https://crrev.com/0362f6002609dca40e53dbc47b4e73b659a31164 Cr-Commit-Position: refs/heads/master@{#294196}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M ui/base/resource/resource_bundle.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
sky
6 years, 3 months ago (2014-09-10 17:06:33 UTC) #1
oshima
lgtm
6 years, 3 months ago (2014-09-10 17:26:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/564473002/1
6 years, 3 months ago (2014-09-10 17:30:21 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as 3b09d34f8746ef787d6da81b4699562f93481dc4
6 years, 3 months ago (2014-09-10 18:33:55 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 18:38:01 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0362f6002609dca40e53dbc47b4e73b659a31164
Cr-Commit-Position: refs/heads/master@{#294196}

Powered by Google App Engine
This is Rietveld 408576698