Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4905)

Unified Diff: chrome/browser/ui/cocoa/profiles/user_manager_mac.h

Issue 564453003: Access to Chrome via the System Tray should go through the User Manager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Pkasting's nits Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/profiles/user_manager_mac.h
diff --git a/chrome/browser/ui/cocoa/profiles/user_manager_mac.h b/chrome/browser/ui/cocoa/profiles/user_manager_mac.h
index e71006271f43fc891082233ea50589b5dccc426d..7167fd1b8912b38600fae0268116698b19f26620 100644
--- a/chrome/browser/ui/cocoa/profiles/user_manager_mac.h
+++ b/chrome/browser/ui/cocoa/profiles/user_manager_mac.h
@@ -22,35 +22,22 @@ class WebContents;
// Dialog widget that contains the Desktop User Manager webui.
class UserManagerMac {
public:
- // Shows the User Manager or re-activates an existing one, focusing the
- // profile given by |profile_path_to_focus|. Based on the value of
- // |tutorial_mode|, a tutorial could be shown, in which case
- // |profile_path_to_focus| is ignored.
- static void Show(const base::FilePath& profile_path_to_focus,
- profiles::UserManagerTutorialMode tutorial_mode);
-
- // Hide the User Manager.
- static void Hide();
-
- // Returns whether or not the User Manager is showing.
- static bool IsShowing();
-
// Called by the cocoa window controller when its window closes and the
// controller destroyed itself. Deletes the instance.
void WindowWasClosed();
- private:
- explicit UserManagerMac(Profile* profile);
- virtual ~UserManagerMac();
-
// Creates a new UserManagerMac instance for the |guest_profile| and
// shows the |url|.
static void OnGuestProfileCreated(Profile* guest_profile,
Alexei Svitkine (slow) 2014/09/18 20:54:04 This is a very strange name for a method when look
Mike Lerman 2014/09/19 15:49:30 Comment added. The UserManager always operates as
const std::string& url);
- // An open User Manager window. There can only be one open at a time. This
- // is reset to NULL when the window is closed.
- static UserManagerMac* instance_; // Weak.
+ UserManagerWindowController* get_window_controller() {
Alexei Svitkine (slow) 2014/09/18 20:54:04 Remove get_ prefixed, it's used for non-trivial me
Mike Lerman 2014/09/19 15:49:30 Done.
+ return window_controller_.get();
+ }
+
+ private:
+ explicit UserManagerMac(Profile* profile);
+ virtual ~UserManagerMac();
// Controller of the window.
base::scoped_nsobject<UserManagerWindowController> window_controller_;

Powered by Google App Engine
This is Rietveld 408576698