Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 564433003: Add AccessorInfo handling into heap profiler. (Closed)

Created:
6 years, 3 months ago by alph
Modified:
6 years, 3 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Add AccessorInfo handling into heap profiler. BUG= R=svenpanne@chromium.org, yurys@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23866

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -0 lines) Patch
M src/heap-snapshot-generator.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/heap-snapshot-generator.cc View 2 chunks +31 lines, -0 lines 0 comments Download
M test/cctest/test-heap-profiler.cc View 1 chunk +40 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
alph
Sven, could you please take a look
6 years, 3 months ago (2014-09-10 13:00:05 UTC) #2
yurys
lgtm
6 years, 3 months ago (2014-09-10 15:13:16 UTC) #3
Sven Panne
lgtm
6 years, 3 months ago (2014-09-11 10:24:53 UTC) #4
alph
6 years, 3 months ago (2014-09-11 11:08:48 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 23866 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698