Issue 56443002: Fix an issue that mediaplayer can return size(0,0) for a valid video

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 56443002: Fix an issue that mediaplayer can return size(0,0) for a valid video (Closed)

Created:
7 years, 1 month ago by qinmin

Modified:
7 years, 1 month ago

Reviewers:
Ted C, no sievers

CC:
chromium-reviews, fischman+watch_chromium.org, jam, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix an issue that mediaplayer can return size(0,0) for a valid video After MediaPlayer get prepared, we query the size from it. However, there are certain cases that the returned size will be (0, 0). Therefore, we cannot rely on the size info if it is empty. For fullscreen video, if the returned size is empty, this change will resize the surfaceView to occupy the entire screen space using the onMeasure() call. BUG=313774 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232575

Patch Set 1 #

Patch Set 2 : Use MATCH_PARENT #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -12 lines)			Patch
	M	content/public/android/java/src/org/chromium/content/browser/ContentVideoView.java	View	1	4 chunks	+8 lines, -10 lines	0 comments	Download
	M	content/renderer/media/android/webmediaplayer_android.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qinmin@chromium.org/56443002/1

7 years, 1 month ago (2013-11-01 21:30:15 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qinmin@chromium.org/56443002/220001

7 years, 1 month ago (2013-11-01 23:48:46 UTC) #4

Message was sent while issue was closed.

Change committed as 232575

Expand Messages | Collapse Messages