Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 564413004: Re-revert "Use unsigned type bitsets to limit undefined behaviour" (Closed)

Created:
6 years, 3 months ago by rossberg
Modified:
6 years, 3 months ago
Reviewers:
Michael Achenbach
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Re-revert "Use unsigned type bitsets to limit undefined behaviour" ...and the various debug CLs. R=machenbach@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=23955

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -188 lines) Patch
M src/types.h View 13 chunks +80 lines, -81 lines 0 comments Download
M src/types.cc View 20 chunks +50 lines, -59 lines 0 comments Download
M src/types-inl.h View 5 chunks +11 lines, -14 lines 0 comments Download
M test/cctest/test-types.cc View 11 chunks +20 lines, -34 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rossberg
6 years, 3 months ago (2014-09-15 15:42:20 UTC) #1
Michael Achenbach
lgtm (rubber-stamp)
6 years, 3 months ago (2014-09-15 15:47:32 UTC) #2
rossberg
6 years, 3 months ago (2014-09-15 15:49:36 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as 23955 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698