Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 564373005: Revert of [Android] Mark posted UI thread tasks as asynchronous (Closed)

Created:
6 years, 3 months ago by jdduke (slow)
Modified:
6 years, 3 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, K Chandrasekhar Omkar, Sami
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of [Android] Mark posted UI thread tasks as asynchronous (patchset #4 id:60001 of https://codereview.chromium.org/512333002/) Reason for revert: This patch was purely experimental, and the experiment has expired. Original issue's description: > [Android] Mark posted UI thread tasks as asynchronous > > Chromium shares a message loop with Android on the browser UI thread. > This can cause problems when the associated Looper has a sync barrier, > preventing posted Chromium tasks from being dispatched until the > barrier is removed. Make this sharing more fair by marking all Chromium > Message tasks as asynchronous, avoiding stalls when there is a sync > barrier. > > Note: This change is for gathering data about the perf impact and we'll > revert it before cutting a release branch. > > BUG=407149, 380781, 407133 > > Committed: https://crrev.com/feabeebb3ac5810f896ac8303a77ee695acaf9d4 > Cr-Commit-Position: refs/heads/master@{#292551} TBR=aelias@chromium.org,epenner@chromium.org,nyquist@chromium.org,sievers@chromium.org,skyostil@chromium.org NOTREECHECKS=true NOTRY=true BUG=407149, 380781, 407133 Committed: https://crrev.com/1dcbab8b36837b7c43bf18f778d0363fa0af9b8a Cr-Commit-Position: refs/heads/master@{#294875}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -49 lines) Patch
M base/android/java/src/org/chromium/base/SystemMessageHandler.java View 5 chunks +2 lines, -49 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jdduke (slow)
Created Revert of [Android] Mark posted UI thread tasks as asynchronous
6 years, 3 months ago (2014-09-15 18:28:32 UTC) #1
aelias_OOO_until_Jul13
lgtm
6 years, 3 months ago (2014-09-15 18:33:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/564373005/1
6 years, 3 months ago (2014-09-15 19:16:42 UTC) #3
nyquist
rs lgtm
6 years, 3 months ago (2014-09-15 19:57:33 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as 2a519e70b3f35fb7f3a944d7a5e92bb96e3e3ab8
6 years, 3 months ago (2014-09-15 20:05:07 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-15 20:06:27 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1dcbab8b36837b7c43bf18f778d0363fa0af9b8a
Cr-Commit-Position: refs/heads/master@{#294875}

Powered by Google App Engine
This is Rietveld 408576698