Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1379)

Issue 564363003: roll-dep: If applicable, include svn revision range in commit message (Closed)

Created:
6 years, 3 months ago by borenet
Modified:
6 years, 3 months ago
Reviewers:
skobes, szager1
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org
Project:
tools
Visibility:
Public.

Description

roll-dep: If applicable, include svn revision range in commit message This is analogous to the change made in https://codereview.chromium.org/559243002/. I want to change ARB to use the commit message generated by roll-dep. BUG=408700 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=291975

Patch Set 1 #

Patch Set 2 : Trim commit msg, use "git rev-parse --short" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -12 lines) Patch
M roll_dep.py View 1 6 chunks +31 lines, -12 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
borenet
Sample commit messages generated after this change: Skia: """ Roll src/third_party/skia from dc53701216c0 to a63d5df455e5 ...
6 years, 3 months ago (2014-09-15 17:05:51 UTC) #2
skobes
LGTM On 2014/09/15 17:05:51, borenet wrote: > The description is longer than 70 chars (81) ...
6 years, 3 months ago (2014-09-15 18:26:29 UTC) #3
iannucci
On 2014/09/15 18:26:29, skobes wrote: > LGTM > > On 2014/09/15 17:05:51, borenet wrote: > ...
6 years, 3 months ago (2014-09-15 18:45:14 UTC) #4
borenet
On 2014/09/15 18:45:14, iannucci wrote: > On 2014/09/15 18:26:29, skobes wrote: > > LGTM > ...
6 years, 3 months ago (2014-09-15 18:51:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/564363003/20001
6 years, 3 months ago (2014-09-15 20:02:02 UTC) #7
commit-bot: I haz the power
Presubmit check for 564363003-20001 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 3 months ago (2014-09-15 20:03:54 UTC) #9
szager1
lgtm
6 years, 3 months ago (2014-09-15 20:57:43 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/564363003/20001
6 years, 3 months ago (2014-09-15 20:58:25 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-15 21:00:25 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 291975

Powered by Google App Engine
This is Rietveld 408576698