[Themes Service] Implement better default value for which Google logo to use.

[Themes Service] Implement better default value for which Google logo to use.

BUG=414120
TEST=Manual, see bug

Committed: https://crrev.com/c23c19880d7f7eec5eee5955f956867f8a54f078
Cr-Commit-Position: refs/heads/master@{#295081}

[huangs, 2014-09-14 23:48:37]

Patchset #1 (id:1) has been deleted

[huangs, 2014-09-14 23:48:54]

huangs@chromium.org changed reviewers:
+ pkotwicz@chromium.org

[huangs, 2014-09-14 23:48:55]

PTAL.

[pkotwicz, 2014-09-16 03:57:18]

LGTM with comments

https://codereview.chromium.org/564353002/diff/20001/chrome/browser/themes/th...
File chrome/browser/themes/theme_service.cc (right):

https://codereview.chromium.org/564353002/diff/20001/chrome/browser/themes/th...
chrome/browser/themes/theme_service.cc:88: // range = max(r, g, b) - min(r, g,
b).
Nit: Use std::max() and std::min(). It makes the code more readable

https://codereview.chromium.org/564353002/diff/20001/chrome/browser/themes/th...
chrome/browser/themes/theme_service.cc:210: // Use colorful logo for
|kDefaultThemeGalleryID| themes.
Remove the comment. It no longer makes sense.

[pkotwicz, 2014-09-16 03:59:58]

I have updated the CL description to make it more descriptive

[huangs, 2014-09-16 15:38:54]

Thanks. Submitting.

https://codereview.chromium.org/564353002/diff/20001/chrome/browser/themes/th...
File chrome/browser/themes/theme_service.cc (right):

https://codereview.chromium.org/564353002/diff/20001/chrome/browser/themes/th...
chrome/browser/themes/theme_service.cc:88: // range = max(r, g, b) - min(r, g,
b).
On 2014/09/16 03:57:18, pkotwicz wrote:
> Nit: Use std::max() and std::min(). It makes the code more readable

Done.

https://codereview.chromium.org/564353002/diff/20001/chrome/browser/themes/th...
chrome/browser/themes/theme_service.cc:210: // Use colorful logo for
|kDefaultThemeGalleryID| themes.
Done; made the comments more succinct.

[huangs, 2014-09-16 15:38:58]

The CQ bit was checked by huangs@chromium.org

[commit-bot: I haz the power, 2014-09-16 15:41:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/564353002/40001

[commit-bot: I haz the power, 2014-09-16 16:38:36]

Committed patchset #2 (id:40001) as 5254e56abac24f75c227bd4f9f8b538720c0d600

[commit-bot: I haz the power, 2014-09-16 16:40:18]

Patchset 2 (id:??) landed as
https://crrev.com/c23c19880d7f7eec5eee5955f956867f8a54f078
Cr-Commit-Position: refs/heads/master@{#295081}