Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: tools/gn/target_generator.h

Issue 56433003: GN threading refactor (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/target.cc ('k') | tools/gn/target_generator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/target_generator.h
diff --git a/tools/gn/target_generator.h b/tools/gn/target_generator.h
index 583e57fc31c61ff30de95a0054611fe51714b9fa..6fa39b19183ff3123f6ca3952108359eceff9ca0 100644
--- a/tools/gn/target_generator.h
+++ b/tools/gn/target_generator.h
@@ -15,9 +15,9 @@
class BuildSettings;
class Err;
+class FunctionCallNode;
class Location;
class Scope;
-class Token;
class Value;
// Fills the variables in a Target object from a Scope (the result of a script
@@ -28,16 +28,16 @@ class TargetGenerator {
public:
TargetGenerator(Target* target,
Scope* scope,
- const Token& function_token,
+ const FunctionCallNode* function_call,
Err* err);
~TargetGenerator();
void Run();
- // The function token is the token of the function name of the generator for
- // this target. err() will be set on failure.
+ // The function call is the parse tree node that invoked the target.
+ // err() will be set on failure.
static void GenerateTarget(Scope* scope,
- const Token& function_token,
+ const FunctionCallNode* function_call,
const std::vector<Value>& args,
const std::string& output_type,
Err* err);
@@ -54,13 +54,9 @@ class TargetGenerator {
void FillExternal();
void FillOutputs();
- // Sets the current toolchain as a dependecy of this target. All targets with
- // a dependency on the toolchain should call this function.
- void SetToolchainDependency();
-
Target* target_;
Scope* scope_;
- const Token& function_token_;
+ const FunctionCallNode* function_call_;
Err* err_;
private:
« no previous file with comments | « tools/gn/target.cc ('k') | tools/gn/target_generator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698