Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: tools/gn/target.h

Issue 56433003: GN threading refactor (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/setup.cc ('k') | tools/gn/target.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/target.h
diff --git a/tools/gn/target.h b/tools/gn/target.h
index 13b278c781f89e2de7cc3e3e207161ad1acada51..58f0de1bffa9772f57068f602f249ddd9ab6f877 100644
--- a/tools/gn/target.h
+++ b/tools/gn/target.h
@@ -51,13 +51,6 @@ class Target : public Item {
virtual const Target* AsTarget() const OVERRIDE;
virtual void OnResolved() OVERRIDE;
- // This flag indicates if we've run the TargetGenerator for this target to
- // fill out the rest of the values. Once we've done this, we save the
- // location of the function that started the generating so that we can detect
- // duplicate declarations.
- bool HasBeenGenerated() const;
- void SetGenerated(const Token* token);
-
OutputType output_type() const { return output_type_; }
void set_output_type(OutputType t) { output_type_ = t; }
@@ -192,9 +185,6 @@ class Target : public Item {
SourceFile gyp_file_;
- bool generated_;
- const Token* generator_function_; // Who generated this: for error messages.
-
DISALLOW_COPY_AND_ASSIGN(Target);
};
« no previous file with comments | « tools/gn/setup.cc ('k') | tools/gn/target.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698