Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: tools/gn/settings.cc

Issue 56433003: GN threading refactor (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/settings.h ('k') | tools/gn/setup.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/settings.cc
diff --git a/tools/gn/settings.cc b/tools/gn/settings.cc
index b8de9766fe97e07a8fe7eff4e5079c3ec720b2d6..2715829998b71202624b3ba381d9b197f9d43c22 100644
--- a/tools/gn/settings.cc
+++ b/tools/gn/settings.cc
@@ -11,7 +11,6 @@
Settings::Settings(const BuildSettings* build_settings,
const std::string& output_subdir_name)
: build_settings_(build_settings),
- is_default_(false),
import_manager_(),
base_config_(this),
greedy_target_generation_(false) {
@@ -23,6 +22,7 @@ Settings::Settings(const BuildSettings* build_settings,
toolchain_output_subdir_.value().append(output_subdir_name);
toolchain_output_subdir_.value().push_back('/');
+ DCHECK(!build_settings->build_dir().is_null());
toolchain_output_dir_ = SourceDir(build_settings->build_dir().value() +
toolchain_output_subdir_.value());
}
@@ -44,5 +44,3 @@ Settings::Settings(const BuildSettings* build_settings,
Settings::~Settings() {
}
-
-
« no previous file with comments | « tools/gn/settings.h ('k') | tools/gn/setup.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698