Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Unified Diff: tools/gn/script_target_generator.cc

Issue 56433003: GN threading refactor (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/script_target_generator.h ('k') | tools/gn/secondary/base/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/script_target_generator.cc
diff --git a/tools/gn/script_target_generator.cc b/tools/gn/script_target_generator.cc
index 272061c488be588e66ae98043c974c6ff80c323f..8f414f4956471fc050ef9a6efbbbf6fa0111d04b 100644
--- a/tools/gn/script_target_generator.cc
+++ b/tools/gn/script_target_generator.cc
@@ -7,16 +7,18 @@
#include "tools/gn/build_settings.h"
#include "tools/gn/err.h"
#include "tools/gn/filesystem_utils.h"
+#include "tools/gn/parse_tree.h"
#include "tools/gn/scope.h"
#include "tools/gn/value.h"
#include "tools/gn/value_extractors.h"
#include "tools/gn/variables.h"
-ScriptTargetGenerator::ScriptTargetGenerator(Target* target,
- Scope* scope,
- const Token& function_token,
- Err* err)
- : TargetGenerator(target, scope, function_token, err) {
+ScriptTargetGenerator::ScriptTargetGenerator(
+ Target* target,
+ Scope* scope,
+ const FunctionCallNode* function_call,
+ Err* err)
+ : TargetGenerator(target, scope, function_call, err) {
}
ScriptTargetGenerator::~ScriptTargetGenerator() {
@@ -62,7 +64,7 @@ void ScriptTargetGenerator::FillScript() {
// if it doesn't have one.
const Value* value = scope_->GetValue(variables::kScript, true);
if (!value) {
- *err_ = Err(function_token_, "This target type requires a \"script\".");
+ *err_ = Err(function_call_, "This target type requires a \"script\".");
return;
}
if (!value->VerifyTypeIs(Value::STRING, err_))
« no previous file with comments | « tools/gn/script_target_generator.h ('k') | tools/gn/secondary/base/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698