Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: tools/gn/scheduler.h

Issue 56433003: GN threading refactor (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/ninja_writer.cc ('k') | tools/gn/scheduler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/scheduler.h
diff --git a/tools/gn/scheduler.h b/tools/gn/scheduler.h
index 4b2c0608742ce8cc4ed391766c3e73738ef84c0a..8f4a13392f898468603d663675ba9f47a92e64f0 100644
--- a/tools/gn/scheduler.h
+++ b/tools/gn/scheduler.h
@@ -40,7 +40,7 @@ class Scheduler {
void ScheduleWork(const base::Closure& work);
- void ScheduleTargetFileWrite(const Target* target);
+ void Shutdown();
// Declares that the given file was read and affected the build output.
//
@@ -79,6 +79,11 @@ class Scheduler {
mutable base::Lock lock_;
bool is_failed_;
+ // Used to track whether the worker pool has been shutdown. This is necessary
+ // to clean up after tests that make a scheduler but don't run the message
+ // loop.
+ bool has_been_shutdown_;
+
// Additional input dependencies. Protected by the lock.
std::vector<base::FilePath> gen_dependencies_;
« no previous file with comments | « tools/gn/ninja_writer.cc ('k') | tools/gn/scheduler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698