Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: tools/gn/ninja_writer.h

Issue 56433003: GN threading refactor (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/ninja_toolchain_writer.cc ('k') | tools/gn/ninja_writer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/ninja_writer.h
diff --git a/tools/gn/ninja_writer.h b/tools/gn/ninja_writer.h
index c2efc9269e44c1f2c9d32d385c98fe0317edccd4..8859f1ad65ec4e7e2c434d097108f87f5283e587 100644
--- a/tools/gn/ninja_writer.h
+++ b/tools/gn/ninja_writer.h
@@ -11,6 +11,7 @@
#include "base/basictypes.h"
+class Builder;
class BuildSettings;
class Settings;
class Target;
@@ -18,31 +19,28 @@ class Target;
class NinjaWriter {
public:
// On failure will print an error and will return false.
- static bool RunAndWriteFiles(const BuildSettings* build_settings);
+ static bool RunAndWriteFiles(const BuildSettings* build_settings,
+ Builder* builder);
// Writes only the toolchain.ninja files, skipping the root buildfile. The
// settings for the files written will be added to the vector.
- //
- // The skip files will avoid writing "subninja" rules when we're doing a
- // side-by-side GYP build. .ninja files exactly matching the ones in the set
- // will be ignored.
static bool RunAndWriteToolchainFiles(
const BuildSettings* build_settings,
- const std::set<std::string>& skip_files,
+ Builder* builder,
std::vector<const Settings*>* all_settings);
private:
- NinjaWriter(const BuildSettings* build_settings);
+ NinjaWriter(const BuildSettings* build_settings, Builder* builder);
~NinjaWriter();
bool WriteToolchains(
- const std::set<std::string>& skip_files,
std::vector<const Settings*>* all_settings,
std::vector<const Target*>* default_targets);
bool WriteRootBuildfiles(const std::vector<const Settings*>& all_settings,
const std::vector<const Target*>& default_targets);
const BuildSettings* build_settings_;
+ Builder* builder_;
DISALLOW_COPY_AND_ASSIGN(NinjaWriter);
};
« no previous file with comments | « tools/gn/ninja_toolchain_writer.cc ('k') | tools/gn/ninja_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698