Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: tools/gn/ninja_toolchain_writer.h

Issue 56433003: GN threading refactor (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/ninja_target_writer.cc ('k') | tools/gn/ninja_toolchain_writer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/ninja_toolchain_writer.h
diff --git a/tools/gn/ninja_toolchain_writer.h b/tools/gn/ninja_toolchain_writer.h
index 5d3daa5252d3291052337507a0a5cb2f9c5f158b..ff0ebc0fffd8e0803e6f1f58827077906dcf34af 100644
--- a/tools/gn/ninja_toolchain_writer.h
+++ b/tools/gn/ninja_toolchain_writer.h
@@ -16,20 +16,20 @@
class BuildSettings;
class Settings;
class Target;
+class Toolchain;
class NinjaToolchainWriter {
public:
// Takes the settings for the toolchain, as well as the list of all targets
- // assicoated with the toolchain. Ninja files exactly matching "skip_files"
- // will not be included in the subninja list.
+ // assicoated with the toolchain.
static bool RunAndWriteFile(const Settings* settings,
- const std::vector<const Target*>& targets,
- const std::set<std::string>& skip_files);
+ const Toolchain* toolchain,
+ const std::vector<const Target*>& targets);
private:
NinjaToolchainWriter(const Settings* settings,
+ const Toolchain* toolchain,
const std::vector<const Target*>& targets,
- const std::set<std::string>& skip_files,
std::ostream& out);
~NinjaToolchainWriter();
@@ -39,8 +39,8 @@ class NinjaToolchainWriter {
void WriteSubninjas();
const Settings* settings_;
+ const Toolchain* toolchain_;
std::vector<const Target*> targets_;
- const std::set<std::string>& skip_files_;
std::ostream& out_;
PathOutput path_output_;
« no previous file with comments | « tools/gn/ninja_target_writer.cc ('k') | tools/gn/ninja_toolchain_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698