Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Unified Diff: tools/gn/item.h

Issue 56433003: GN threading refactor (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/input_file_manager.cc ('k') | tools/gn/item.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/item.h
diff --git a/tools/gn/item.h b/tools/gn/item.h
index 69115bd7b3e664dd67352834f0daded786d53f67..4d9f25beb04090354cbe4048c5fa530d85eb5638 100644
--- a/tools/gn/item.h
+++ b/tools/gn/item.h
@@ -10,7 +10,7 @@
#include "tools/gn/label.h"
class Config;
-class ItemNode;
+class ParseNode;
class Settings;
class Target;
class Toolchain;
@@ -28,12 +28,8 @@ class Item {
// accessed from any thread with no locking once the item is constructed.
const Label& label() const { return label_; }
- // The Item and the ItemNode make a pair. This will be set when the ItemNode
- // is constructed that owns this Item. The ItemNode should only be
- // dereferenced with the ItemTree lock held.
- ItemNode* item_node() { return item_node_; }
- const ItemNode* item_node() const { return item_node_; }
- void set_item_node(ItemNode* in) { item_node_ = in; }
+ const ParseNode* defined_from() const { return defined_from_; }
+ void set_defined_from(const ParseNode* df) { defined_from_ = df; }
// Manual RTTI.
virtual Config* AsConfig();
@@ -54,8 +50,7 @@ class Item {
private:
const Settings* settings_;
Label label_;
-
- ItemNode* item_node_;
+ const ParseNode* defined_from_;
};
#endif // TOOLS_GN_ITEM_H_
« no previous file with comments | « tools/gn/input_file_manager.cc ('k') | tools/gn/item.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698