Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: tools/gn/config_values_generator.h

Issue 56433003: GN threading refactor (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/config.cc ('k') | tools/gn/config_values_generator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/config_values_generator.h
diff --git a/tools/gn/config_values_generator.h b/tools/gn/config_values_generator.h
index d58018e35d59e9db0294fb4aa34b891ff72a139b..eb8a2e6b1668b7216aa3bec0a7e32b7b6e8e0511 100644
--- a/tools/gn/config_values_generator.h
+++ b/tools/gn/config_values_generator.h
@@ -16,11 +16,14 @@ class Err;
class Scope;
class Token;
+// This class fills in the config values from a given scope. It's shared
+// between the "config" function call and all the different binary target types
+// (shared library, static library, etc.) since all of these support the
+// various flags stored in the ConfigValues class.
class ConfigValuesGenerator {
public:
ConfigValuesGenerator(ConfigValues* dest_values,
Scope* scope,
- const Token& function_token,
const SourceDir& input_dir,
Err* err);
~ConfigValuesGenerator();
@@ -31,7 +34,6 @@ class ConfigValuesGenerator {
private:
ConfigValues* config_values_;
Scope* scope_;
- const Token& function_token_;
const SourceDir input_dir_;
Err* err_;
« no previous file with comments | « tools/gn/config.cc ('k') | tools/gn/config_values_generator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698