Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Unified Diff: tools/gn/config.h

Issue 56433003: GN threading refactor (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/commands.cc ('k') | tools/gn/config.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/config.h
diff --git a/tools/gn/config.h b/tools/gn/config.h
index e5a1df6d7eeee7bdbb1a9fdab95eb6943c74ce60..f08b85915302f6f22cc8848c5eaaa6e96bbb2934 100644
--- a/tools/gn/config.h
+++ b/tools/gn/config.h
@@ -9,11 +9,6 @@
#include "tools/gn/config_values.h"
#include "tools/gn/item.h"
-class Err;
-class ItemTree;
-class LocationRange;
-class Settings;
-
// Represents a named config in the dependency graph.
class Config : public Item {
public:
@@ -26,16 +21,6 @@ class Config : public Item {
ConfigValues& config_values() { return config_values_; }
const ConfigValues& config_values() const { return config_values_; }
- // Gets or creates a config.
- //
- // This is like the TargetManager is for Targets, but Configs are so much
- // simpler that this one function is all we need.
- static Config* GetConfig(const Settings* settings,
- const LocationRange& specified_from_here,
- const Label& label,
- Item* dep_from,
- Err* err);
-
private:
ConfigValues config_values_;
« no previous file with comments | « tools/gn/commands.cc ('k') | tools/gn/config.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698