Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Unified Diff: tools/gn/binary_target_generator.cc

Issue 56433003: GN threading refactor (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/binary_target_generator.h ('k') | tools/gn/build_settings.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/binary_target_generator.cc
diff --git a/tools/gn/binary_target_generator.cc b/tools/gn/binary_target_generator.cc
index b8d2d6e6ba801f0e5f1ee397e44ceaaac219a385..3aec119e12ec0b73623986ad2f7c76bfa28bfcbe 100644
--- a/tools/gn/binary_target_generator.cc
+++ b/tools/gn/binary_target_generator.cc
@@ -9,12 +9,13 @@
#include "tools/gn/scope.h"
#include "tools/gn/variables.h"
-BinaryTargetGenerator::BinaryTargetGenerator(Target* target,
- Scope* scope,
- const Token& function_token,
- Target::OutputType type,
- Err* err)
- : TargetGenerator(target, scope, function_token, err),
+BinaryTargetGenerator::BinaryTargetGenerator(
+ Target* target,
+ Scope* scope,
+ const FunctionCallNode* function_call,
+ Target::OutputType type,
+ Err* err)
+ : TargetGenerator(target, scope, function_call, err),
output_type_(type) {
}
@@ -46,12 +47,10 @@ void BinaryTargetGenerator::DoRun() {
// Config values (compiler flags, etc.) set directly on this target.
ConfigValuesGenerator gen(&target_->config_values(), scope_,
- function_token_, scope_->GetSourceDir(), err_);
+ scope_->GetSourceDir(), err_);
gen.Run();
if (err_->has_error())
return;
-
- SetToolchainDependency();
}
void BinaryTargetGenerator::FillOutputName() {
« no previous file with comments | « tools/gn/binary_target_generator.h ('k') | tools/gn/build_settings.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698