Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 564193002: Clean up forward declarations in Source/core/loader (Closed)

Created:
6 years, 3 months ago by rwlbuis
Modified:
6 years, 3 months ago
Reviewers:
Nate Chapin
CC:
blink-reviews, Nate Chapin, gavinp+prerender_chromium.org, gavinp+loader_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Clean up forward declarations in Source/core/loader These forward references are not needed anymore. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181940

Patch Set 1 #

Patch Set 2 : Add MixedContentChecker #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -57 lines) Patch
M Source/core/loader/DocumentLoadTiming.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/loader/DocumentLoader.h View 1 1 chunk +0 lines, -9 lines 0 comments Download
M Source/core/loader/DocumentWriter.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/loader/FormSubmission.h View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/loader/FrameFetchContext.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/loader/FrameLoadRequest.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/loader/FrameLoader.h View 1 1 chunk +0 lines, -9 lines 0 comments Download
M Source/core/loader/FrameLoaderClient.h View 2 chunks +0 lines, -12 lines 0 comments Download
M Source/core/loader/HistoryItem.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/loader/MixedContentChecker.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/loader/PingLoader.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/loader/PrerendererClient.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/loader/ThreadableLoader.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/loader/WorkerThreadableLoader.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/loader/appcache/ApplicationCache.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/loader/appcache/ApplicationCacheHost.h View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
rwlbuis
PTAL
6 years, 3 months ago (2014-09-12 20:57:27 UTC) #2
Nate Chapin
Rubberstamp LGTM, so long as it compliles. :)
6 years, 3 months ago (2014-09-12 21:03:52 UTC) #3
rwlbuis
On 2014/09/12 21:03:52, Nate Chapin wrote: > Rubberstamp LGTM, so long as it compliles. :) ...
6 years, 3 months ago (2014-09-12 21:06:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/564193002/20001
6 years, 3 months ago (2014-09-12 21:11:26 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 22:20:24 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 181940

Powered by Google App Engine
This is Rietveld 408576698