Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 564133003: Make better use of MediaTypeNames (Closed)

Created:
6 years, 3 months ago by rwlbuis
Modified:
6 years, 3 months ago
Reviewers:
adamk, abarth-chromium
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, dglazkov+blink, krit, ed+blinkwatch_opera.com, f(malita), fs, gyuyoung.kim_webkit.org, kouhei+svg_chromium.org, pdr., rune+blink, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Make better use of MediaTypeNames These places may as well just use the global strings from MediaTypeNames. This CL also removes the unused speechButton method. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182012

Patch Set 1 #

Patch Set 2 : Add more #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -13 lines) Patch
M Source/core/css/parser/BisonCSSParser-in.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M Source/core/frame/FrameView.cpp View 1 3 chunks +3 lines, -2 lines 0 comments Download
M Source/core/html/shadow/ShadowElementNames.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/shadow/ShadowElementNames.cpp View 1 1 chunk +0 lines, -6 lines 1 comment Download
M Source/core/svg/SVGStyleElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
rwlbuis
PTAL
6 years, 3 months ago (2014-09-12 19:59:38 UTC) #2
adamk
lgtm https://codereview.chromium.org/564133003/diff/20001/Source/core/html/shadow/ShadowElementNames.cpp File Source/core/html/shadow/ShadowElementNames.cpp (left): https://codereview.chromium.org/564133003/diff/20001/Source/core/html/shadow/ShadowElementNames.cpp#oldcode110 Source/core/html/shadow/ShadowElementNames.cpp:110: const AtomicString& speechButton() Guessing this was unused? Deserves ...
6 years, 3 months ago (2014-09-15 17:36:01 UTC) #3
rwlbuis
On 2014/09/15 17:36:01, adamk wrote: > lgtm > > https://codereview.chromium.org/564133003/diff/20001/Source/core/html/shadow/ShadowElementNames.cpp > File Source/core/html/shadow/ShadowElementNames.cpp (left): > ...
6 years, 3 months ago (2014-09-15 17:36:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/564133003/20001
6 years, 3 months ago (2014-09-15 17:39:02 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-15 22:15:44 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 182012

Powered by Google App Engine
This is Rietveld 408576698