Measure resources from private IP addresses in public websites.

Measure resources from private IP addresses in public websites.

This patch gathers data in the hopes of measuring the impact of locking
down private-IP-address subresources in public-IP-address sites. It does
so after the response has been delivered, so it's not the way we'd want
to do checking if we wanted to block the request, but it's a good way of
getting numbers so we can make decisions.

BUG=378566
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182053

[Mike West, 2014-09-12 15:12:01]

mkwst@chromium.org changed reviewers:
+ cbentzel@chromium.org, palmer@chromium.org, rsleevi@chromium.org

[Mike West, 2014-09-12 15:12:02]

A different approach to measuring mixed private/public resources on the web.
Chris suggested that we could measure the responses to get data, and it turns
out that we're already piping IP addresses down into Blink. Hooray?

WDYT of this patch?

-mike

[cbentzel, 2014-09-12 15:41:10]

Seems like a good way to be able to get mixed_public_private/page_load metrics
without having to mess with NavigationEntry or similar on the Chrome/browser
side.

https://codereview.chromium.org/564123002/diff/1/Source/core/loader/MixedCont...
File Source/core/loader/MixedContentChecker.cpp (right):

https://codereview.chromium.org/564123002/diff/1/Source/core/loader/MixedCont...
Source/core/loader/MixedContentChecker.cpp:348: bool
MixedContentChecker::checkMixedPrivatePublic(LocalFrame* frame, const
AtomicString& resourceIPAddress)
return bool is not being used.

Probably want to either make it void return value, or return boolean and have
caller feed that into UseCounter rather than doing it in here.

[Mike West, 2014-09-13 04:04:33]

Thanks for taking a look!

https://codereview.chromium.org/564123002/diff/1/Source/core/loader/MixedCont...
File Source/core/loader/MixedContentChecker.cpp (right):

https://codereview.chromium.org/564123002/diff/1/Source/core/loader/MixedCont...
Source/core/loader/MixedContentChecker.cpp:348: bool
MixedContentChecker::checkMixedPrivatePublic(LocalFrame* frame, const
AtomicString& resourceIPAddress)
On 2014/09/12 15:41:10, cbentzel wrote:
> return bool is not being used.
> 
> Probably want to either make it void return value, or return boolean and have
> caller feed that into UseCounter rather than doing it in here.

Dropped the bool. If/when we decide to start blocking, we can add it back.

[Mike West, 2014-09-16 07:54:54]

mkwst@chromium.org changed reviewers:
+ jochen@chromium.org

[Mike West, 2014-09-16 07:54:54]

Jochen, would you mind stamping this UseCounter addition as well? :) None of my
PST friends said the magic words.

-mike

[jochen (gone - plz use gerrit), 2014-09-16 14:43:45]

lgtm

[Mike West, 2014-09-16 14:48:27]

The CQ bit was checked by mkwst@chromium.org

[commit-bot: I haz the power, 2014-09-16 14:49:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/564123002/40001

[commit-bot: I haz the power, 2014-09-16 14:56:28]

Committed patchset #3 (id:40001) as 182053