Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issue 564073002: Changing the order of initialization WeakPtrFactory (Closed)

Created:
6 years, 3 months ago by ARUNKK
Modified:
6 years, 3 months ago
Reviewers:
oshima, sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Changing the order of initialization WeakPtrFactory Changing in the intialization order of WeakPtrFactory in src/athena module such that all member variables should appear before the WeakPtrFactory to ensure that any WeakPtrs to Controller are invalidated before its members variable's destructors are executed, rendering them invalid. BUG=303818 Committed: https://crrev.com/5231c93b459024813adb2dddd54d54add5666931 Cr-Commit-Position: refs/heads/master@{#294574}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M athena/system/network_selector.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
ARUNKK
oshima@chromium.org: Please review changes in sky@chromium.org: Please review changes in PTAL.
6 years, 3 months ago (2014-09-12 09:56:45 UTC) #2
oshima
lgtm
6 years, 3 months ago (2014-09-12 10:32:38 UTC) #3
ARUNKK
On 2014/09/12 10:32:38, oshima wrote: > lgtm Thanks for review and lgtm.
6 years, 3 months ago (2014-09-12 10:33:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/564073002/1
6 years, 3 months ago (2014-09-12 10:34:24 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as a0533ae15d3bcb255ad944088d70e19e37e158da
6 years, 3 months ago (2014-09-12 11:34:21 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 11:36:40 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5231c93b459024813adb2dddd54d54add5666931
Cr-Commit-Position: refs/heads/master@{#294574}

Powered by Google App Engine
This is Rietveld 408576698