Source/bindings/tests/results/core/V8TestInterfaceConstructor2.cpp - Issue 564063002: Generate simple code for "trivial" conversions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/core/V8TestInterfaceConstructor2.cpp

Issue 564063002: Generate simple code for "trivial" conversions (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rebased Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/tests/results/core/V8TestInterfaceConstructor2.cpp

diff --git a/Source/bindings/tests/results/core/V8TestInterfaceConstructor2.cpp b/Source/bindings/tests/results/core/V8TestInterfaceConstructor2.cpp

index fa4773b24092839d75d7565ccc0c35a0c795cff0..faffabd143ec0ddd9a353c1e73ecf5eb55e10662 100644

--- a/Source/bindings/tests/results/core/V8TestInterfaceConstructor2.cpp

+++ b/Source/bindings/tests/results/core/V8TestInterfaceConstructor2.cpp

@@ -76,7 +76,7 @@ static void constructor3(const v8::FunctionCallbackInfo<v8::Value>& info)

{

v8::TryCatch block;

V8RethrowTryCatchScope rethrow(block);

- TONATIVE_VOID_INTERNAL(testInterfaceEmptyArg, V8TestInterfaceEmpty::toImplWithTypeCheck(info.GetIsolate(), info[0]));

+ testInterfaceEmptyArg = V8TestInterfaceEmpty::toImplWithTypeCheck(info.GetIsolate(), info[0]);

TONATIVE_VOID_EXCEPTIONSTATE_INTERNAL(longArg, toInt32(info[1], exceptionState), exceptionState);

TOSTRING_VOID_INTERNAL(defaultUndefinedOptionalStringArg, info[2]);

if (!info[3]->IsUndefined()) {