Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Unified Diff: Source/bindings/scripts/v8_methods.py

Issue 564063002: Generate simple code for "trivial" conversions (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: rebased Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/scripts/v8_types.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/v8_methods.py
diff --git a/Source/bindings/scripts/v8_methods.py b/Source/bindings/scripts/v8_methods.py
index dcd04ae097f1bf7a9dd2002e9d26a6c925f4d9dd..2cbf6e2ac0b6e601aee6a7fc84547eca1e08b7b5 100644
--- a/Source/bindings/scripts/v8_methods.py
+++ b/Source/bindings/scripts/v8_methods.py
@@ -73,7 +73,10 @@ def argument_needs_try_catch(method, argument):
# exceptions via it, and doesn't need/use a TryCatch, except if the
# argument has [Clamp], in which case it uses a separate code path in
# Source/bindings/templates/methods.cpp, which *does* use a TryCatch.
- idl_type.v8_conversion_needs_exception_state)
+ idl_type.v8_conversion_needs_exception_state or
+ # A trivial conversion cannot throw exceptions at all, so doesn't need a
+ # TryCatch to catch them.
+ idl_type.v8_conversion_is_trivial)
def use_local_result(method):
« no previous file with comments | « no previous file | Source/bindings/scripts/v8_types.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698