Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 564053002: AX: Calendar Picker: Apply aria-activedescendant to YearListView. (Closed)

Created:
6 years, 3 months ago by tkent
Modified:
6 years, 3 months ago
Reviewers:
keishi
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

AX: Calendar Picker: Apply aria-activedescendant to YearListView. Month buttons should have role=gridcell, and YearListCell should not. So this CL moves role=gridcell from ListCell to DayCell. Month buttons should have their own IDs, and readable month label. BUG=123896 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181887

Patch Set 1 #

Patch Set 2 : Fix the test for Windows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -9 lines) Patch
M LayoutTests/fast/forms/calendar-picker/date-picker-ax.html View 1 2 chunks +15 lines, -3 lines 0 comments Download
M LayoutTests/fast/forms/calendar-picker/date-picker-ax-expected.txt View 1 1 chunk +10 lines, -2 lines 0 comments Download
M Source/web/resources/calendarPicker.js View 6 chunks +17 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
tkent
Please review this.
6 years, 3 months ago (2014-09-12 07:36:02 UTC) #2
keishi
lgtm
6 years, 3 months ago (2014-09-12 07:45:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/564053002/20001
6 years, 3 months ago (2014-09-12 09:05:02 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 09:14:51 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 181887

Powered by Google App Engine
This is Rietveld 408576698