Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Unified Diff: chrome/browser/chromeos/extensions/device_local_account_management_policy_provider_unittest.cc

Issue 564043004: Remove implicit conversions from scoped_refptr to T* in extensions code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/extensions/external_cache.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/extensions/device_local_account_management_policy_provider_unittest.cc
diff --git a/chrome/browser/chromeos/extensions/device_local_account_management_policy_provider_unittest.cc b/chrome/browser/chromeos/extensions/device_local_account_management_policy_provider_unittest.cc
index 3dae3ebb6b058351b8a1292d0289bc162ce51ec8..c6f974d7e5f75b0b26859ba1f0f63d0d49069c61 100644
--- a/chrome/browser/chromeos/extensions/device_local_account_management_policy_provider_unittest.cc
+++ b/chrome/browser/chromeos/extensions/device_local_account_management_policy_provider_unittest.cc
@@ -79,7 +79,7 @@ TEST(DeviceLocalAccountManagementPolicyProviderTest, PublicSession) {
// public sessions, the extension can be installed.
scoped_refptr<const extensions::Extension> extension =
CreateExternalComponentExtension();
- ASSERT_TRUE(extension);
+ ASSERT_TRUE(extension.get());
base::string16 error;
EXPECT_TRUE(provider.UserMayLoad(extension.get(), &error));
EXPECT_EQ(base::string16(), error);
@@ -88,7 +88,7 @@ TEST(DeviceLocalAccountManagementPolicyProviderTest, PublicSession) {
// Verify that if an extension's type has been whitelisted for use in
// device-local accounts, the extension can be installed.
extension = CreateHostedApp();
- ASSERT_TRUE(extension);
+ ASSERT_TRUE(extension.get());
EXPECT_TRUE(provider.UserMayLoad(extension.get(), &error));
EXPECT_EQ(base::string16(), error);
error.clear();
@@ -96,7 +96,7 @@ TEST(DeviceLocalAccountManagementPolicyProviderTest, PublicSession) {
// Verify that if an extension's ID has been explicitly whitelisted for use in
// device-local accounts, the extension can be installed.
extension = CreateRegularExtension(kWhitelistedId);
- ASSERT_TRUE(extension);
+ ASSERT_TRUE(extension.get());
EXPECT_TRUE(provider.UserMayLoad(extension.get(), &error));
EXPECT_EQ(base::string16(), error);
error.clear();
@@ -105,7 +105,7 @@ TEST(DeviceLocalAccountManagementPolicyProviderTest, PublicSession) {
// been whitelisted for use in public sessions, the extension cannot be
// installed.
extension = CreateRegularExtension(std::string());
- ASSERT_TRUE(extension);
+ ASSERT_TRUE(extension.get());
EXPECT_FALSE(provider.UserMayLoad(extension.get(), &error));
EXPECT_NE(base::string16(), error);
error.clear();
@@ -117,7 +117,7 @@ TEST(DeviceLocalAccountManagementPolicyProviderTest, KioskAppSession) {
// Verify that a platform app can be installed.
scoped_refptr<const extensions::Extension> extension = CreatePlatformApp();
- ASSERT_TRUE(extension);
+ ASSERT_TRUE(extension.get());
base::string16 error;
EXPECT_TRUE(provider.UserMayLoad(extension.get(), &error));
EXPECT_EQ(base::string16(), error);
@@ -127,7 +127,7 @@ TEST(DeviceLocalAccountManagementPolicyProviderTest, KioskAppSession) {
// other types of device-local accounts cannot be installed in a single-app
// kiosk session.
extension = CreateExternalComponentExtension();
- ASSERT_TRUE(extension);
+ ASSERT_TRUE(extension.get());
EXPECT_FALSE(provider.UserMayLoad(extension.get(), &error));
EXPECT_NE(base::string16(), error);
error.clear();
@@ -136,7 +136,7 @@ TEST(DeviceLocalAccountManagementPolicyProviderTest, KioskAppSession) {
// types of device-local accounts cannot be installed in a single-app kiosk
// session.
extension = CreateHostedApp();
- ASSERT_TRUE(extension);
+ ASSERT_TRUE(extension.get());
EXPECT_FALSE(provider.UserMayLoad(extension.get(), &error));
EXPECT_NE(base::string16(), error);
error.clear();
@@ -145,7 +145,7 @@ TEST(DeviceLocalAccountManagementPolicyProviderTest, KioskAppSession) {
// types of device-local accounts cannot be installed in a single-app kiosk
// session.
extension = CreateRegularExtension(kWhitelistedId);
- ASSERT_TRUE(extension);
+ ASSERT_TRUE(extension.get());
EXPECT_FALSE(provider.UserMayLoad(extension.get(), &error));
EXPECT_NE(base::string16(), error);
error.clear();
« no previous file with comments | « no previous file | chrome/browser/chromeos/extensions/external_cache.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698