Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 564035: Remove lazy loading of natives files and the natives cache.... (Closed)

Created:
10 years, 10 months ago by Erik Corry
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Remove lazy loading of natives files and the natives cache. This patch also contains some printf debug lines that should be removed before the branch is merged back in. Known bugs: * The call to the API test fuzzer was removed from call_as_function in test-api.cc. This may indicate a problem with stack cooking and uncooking of apply frames. * The test EquivalenceOfLoggingAndTraversal has started failing. This is probably just the result of code being on the heap that wouldn't be there if the regexp.js file was lazily loaded. * Performance is down of course. Also contains a fix for large objects in the snapshot. Support for an external natives file is removed. Committed: http://code.google.com/p/v8/source/detail?r=3780

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+185 lines, -6605 lines) Patch
M src/SConscript View 1 chunk +5 lines, -5 lines 0 comments Download
M src/api.cc View 2 chunks +9 lines, -6 lines 0 comments Download
M src/apinatives.js View 1 chunk +1 line, -1 line 0 comments Download
M src/bootstrapper.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/bootstrapper.cc View 8 chunks +19 lines, -59 lines 0 comments Download
M src/compilation-cache.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler.cc View 2 chunks +5 lines, -1 line 0 comments Download
A + src/date.js View 0 chunks +-1 lines, --1 lines 0 comments Download
D src/date-delay.js View 1 chunk +0 lines, -1138 lines 0 comments Download
M src/debug.cc View 3 chunks +8 lines, -3 lines 0 comments Download
A + src/debug-debugger.js View 0 chunks +-1 lines, --1 lines 0 comments Download
D src/debug-delay.js View 1 chunk +0 lines, -2073 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/frames.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/globals.h View 2 chunks +5 lines, -1 line 0 comments Download
M src/handles.h View 1 chunk +0 lines, -7 lines 0 comments Download
M src/handles.cc View 1 chunk +0 lines, -83 lines 0 comments Download
M src/heap.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/ia32/ic-ia32.cc View 4 chunks +0 lines, -24 lines 0 comments Download
M src/ic.cc View 11 chunks +4 lines, -13 lines 0 comments Download
A + src/json.js View 0 chunks +-1 lines, --1 lines 0 comments Download
D src/json-delay.js View 1 chunk +0 lines, -254 lines 0 comments Download
M src/jsregexp.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/macros.py View 1 chunk +0 lines, -4 lines 0 comments Download
M src/messages.js View 5 chunks +14 lines, -4 lines 0 comments Download
A + src/mirror-debugger.js View 1 chunk +0 lines, -7 lines 0 comments Download
D src/mirror-delay.js View 1 chunk +0 lines, -2334 lines 0 comments Download
M src/mksnapshot.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/natives.h View 1 chunk +6 lines, -6 lines 0 comments Download
M src/objects.h View 5 chunks +1 line, -32 lines 0 comments Download
M src/objects.cc View 6 chunks +0 lines, -67 lines 0 comments Download
M src/objects-debug.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/objects-inl.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/platform-win32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/property.h View 1 chunk +0 lines, -9 lines 0 comments Download
A + src/regexp.js View 0 chunks +-1 lines, --1 lines 0 comments Download
D src/regexp-delay.js View 1 chunk +0 lines, -406 lines 0 comments Download
M src/runtime.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/serialize.h View 4 chunks +52 lines, -21 lines 0 comments Download
M src/serialize.cc View 3 chunks +4 lines, -1 line 0 comments Download
M src/string.js View 2 chunks +3 lines, -3 lines 0 comments Download
M src/v8threads.cc View 5 chunks +5 lines, -0 lines 0 comments Download
M test/cctest/cctest.status View 2 chunks +3 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-compiler.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M test/cctest/test-serialize.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/mjsunit/debug-script.js View 1 chunk +1 line, -1 line 0 comments Download
M tools/js2c.py View 7 chunks +22 lines, -22 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Erik Corry
10 years, 10 months ago (2010-02-03 09:59:17 UTC) #1
Mads Ager (chromium)
10 years, 10 months ago (2010-02-03 10:35:21 UTC) #2
LGTM for the branch.  Let's make sure to give everything a full review when
merging back to bleeding_edge.

Powered by Google App Engine
This is Rietveld 408576698